Re: [Qemu-devel] [PATCH v2 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

[Phil Dennis-Jordan]

On 15 March 2017 at 08:29, Michael S. Tsirkin <address@hidden> wrote:
>
> On Sat, Mar 11, 2017 at 10:06:22PM -0800, address@hidden wrote:
> > Hi,
> >
> > This series failed automatic build test. Please find the testing commands 
> > and
> > their output below. If you have docker installed, you can probably 
> > reproduce it
> > locally.
> >
> > Type: series
> > Subject: [Qemu-devel] [PATCH v2 0/2] hw/i386: Update FADT to Revision 3 
> > (ACPI 2.0)
> > Message-id: address@hidden
> >   LINK    tests/check-qlist
> > /tmp/qemu-test/src/tests/bios-tables-test.c: In function 
> > ‘test_acpi_fadt_table’:
> > /tmp/qemu-test/src/tests/bios-tables-test.c:171: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:171: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:171: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:171: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:171: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:171: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:172: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4a’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:172: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4a’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:172: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4a’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:172: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4a’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:172: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4a’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:172: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4a’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:173: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4b’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:173: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4b’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:173: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4b’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:173: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4b’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:173: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4b’
> > /tmp/qemu-test/src/tests/bios-tables-test.c:173: error: 
> > ‘AcpiFadtDescriptorRev3’ has no member named ‘reserved4b’
> > make: *** [tests/bios-tables-test.o] Error 1
> > make: *** Waiting for unfinished jobs....
> > make: *** wait: No child processes.  Stop.
> > make[1]: *** [docker-run] Error 2
> > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-c8855z5b/src'
> > make: *** address@hidden Error 2
> > === OUTPUT END ===
>
> Hi Phil, did you run make check? Please make sure it isn't
> broken by any of your patches.


Sorry for the noise - I originally wrote most of the patch weeks ago
and on getting back to it forgot I hadn't sorted out the test
situation. I've just posted version 3, which does indeed pass make
check.