Re: [Qemu-devel] [PATCH v2] coverity-model: model address_space_read/write

[Peter Maydell]

On 15 March 2017 at 11:55, Eric Blake <address@hidden> wrote:
> On 03/15/2017 03:16 AM, Paolo Bonzini wrote:
>> -MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, MemTxAttrs 
>> attrs,
>> -                             uint8_t *buf, int len, bool is_write)
>> +MemTxResult address_space_read(AddressSpace *as, hwaddr addr,
>> +                               MemTxAttrs attrs,
>> +                               uint8_t *buf, int len)
>>  {
>>      MemTxResult result;
>> -
>>      // TODO: investigate impact of treating reads as producing
>>      // tainted data, with __coverity_tainted_data_argument__(buf).
>> -    if (is_write) __bufread(buf, len); else __bufwrite(buf, len);
>
> Old code did __bufread for reads,

Eh? for a read is_write is false, and we use the else clause,
which is __bufwrite...

thanks
-- PMM