Re: [Qemu-devel] [PATCH v2 for-2.9 31/47] qapi: Fix detection of doc / expression mismatch

[Eric Blake]

On 03/15/2017 07:57 AM, Markus Armbruster wrote:
> This fixes the errors uncovered by the previous commit.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---

>  def check_freeform_doc(doc):
> -    if doc.symbol:
> -        raise QAPISemError(doc.info,
> -                           "Documention for '%s' is not followed"
> -                           " by the definition" % doc.symbol)

> +++ b/tests/qapi-schema/doc-missing-expr.err
> @@ -1 +1 @@
> -tests/qapi-schema/doc-missing-expr.json:3: Documention for 'bar' is not 
> followed by the definition
> +tests/qapi-schema/doc-missing-expr.json:3: Documentation for 'bar' is not 
> followed by the definition

I didn't even catch that you were also fixing the typo, on my last round
of reviews :)

R-b stands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature