[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/7] virtio-pci: reset modern vq meta data
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 7/7] virtio-pci: reset modern vq meta data |
Date: |
Wed, 15 Mar 2017 20:01:44 +0200 |
From: Jason Wang <address@hidden>
We don't reset proxy->vqs[].{num|desc[]|avail[]|used[]}. This means if
a driver enable the vq without setting vq address after reset. The old
addresses were leaked. Fixing this by resetting modern vq meta data
during device reset.
Cc: address@hidden
Signed-off-by: Jason Wang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/virtio/virtio-pci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 5ce42af..69cc471 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1857,6 +1857,10 @@ static void virtio_pci_reset(DeviceState *qdev)
for (i = 0; i < VIRTIO_QUEUE_MAX; i++) {
proxy->vqs[i].enabled = 0;
+ proxy->vqs[i].num = 0;
+ proxy->vqs[i].desc[0] = proxy->vqs[i].desc[1] = 0;
+ proxy->vqs[i].avail[0] = proxy->vqs[i].avail[1] = 0;
+ proxy->vqs[i].used[0] = proxy->vqs[i].used[1] = 0;
}
}
--
MST
- [Qemu-devel] [PULL 0/7] virtio, pc: fixes, Michael S. Tsirkin, 2017/03/15
- [Qemu-devel] [PULL 2/7] virtio: guard against NULL pfn, Michael S. Tsirkin, 2017/03/15
- [Qemu-devel] [PULL 1/7] Bugfix: Handle error if VM Generation ID device not present, Michael S. Tsirkin, 2017/03/15
- [Qemu-devel] [PULL 3/7] virtio: destroy region cache during reset, Michael S. Tsirkin, 2017/03/15
- [Qemu-devel] [PULL 4/7] virtio: validate address space cache during init, Michael S. Tsirkin, 2017/03/15
- [Qemu-devel] [PULL 6/7] Revert "virtio: unbreak virtio-pci with IOMMU after caching ring translations", Michael S. Tsirkin, 2017/03/15
- [Qemu-devel] [PULL 5/7] pci: introduce a bus master container, Michael S. Tsirkin, 2017/03/15
- [Qemu-devel] [PULL 7/7] virtio-pci: reset modern vq meta data,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL 0/7] virtio, pc: fixes, Peter Maydell, 2017/03/15