Re: [Qemu-devel] [RFC PATCH v2 30/30] trace: Force compiler warnings on trace parameter type mismatches

[Stefan Hajnoczi]

On Wed, Mar 15, 2017 at 02:59:55PM -0500, Eric Blake wrote:
> On 03/13/2017 02:55 PM, Eric Blake wrote:
> > 2. there are still failures under 'make address@hidden'
> > due to more type mismatches that still need to be squashed. I'm
> > still working on fixing those, but wanted to at least post this
> > series for initial review, especially so the maintainer can weigh
> > in on how much (or little) belongs in 2.9
> 
> mingw is a nightmare.  Things like ntohl() having non-standard behavior
> on 32-bit mingw can only be worked around by hairy redefinitions in
> osdep.h or by casts at the callsites. See the conversation in 6/30, but
> I'm hoping gcc will give us a new knob to tone down the level of
> -Wformat warnings for two types that have different rank but the same
> width; if gcc gives us that, then we'd add a configure test, and
> conditionally generate the type-mismatch checking code ONLY when gcc is
> smart enough to not care about rank mismatch.  Until then, this RFC
> 30/30 proved useful for flushing out the earlier cleanups (many of which
> you can/should still accept), but should NOT be incorporated as-is, not
> even when 2.10 opens.

QEMU 2.9 regression fixes are appropriate at this stage in the release
process.

Fixes for bugs already in 2.8 are less likely to be merged as we head
towards -rc2/-rc3.

Stefan

signature.asc
Description: PGP signature