Re: [Qemu-devel] [PATCH] target-x86:Add GDB XML register description support

[Paolo Bonzini]

On 16/03/2017 14:02, Abdallah Bouassida wrote:
>>
>>  X86CPU *cpu_x86_init(const char *cpu_model)
>>  {
>>      return X86_CPU(cpu_generic_init(TYPE_X86_CPU, cpu_model));
>> @@ -3720,10 +3729,14 @@ static void
>> x86_cpu_common_class_init(ObjectClass *oc, void *data)
>>      cc->write_elf32_qemunote = x86_cpu_write_elf32_qemunote;
>>      cc->vmsd = &vmstate_x86_cpu;
>>  #endif
>> -    /* CPU_NB_REGS * 2 = general regs + xmm regs
>> -     * 25 = eip, eflags, 6 seg regs, st[0-7], fctrl,...,fop, mxcsr.
>> -     */
>> -    cc->gdb_num_core_regs = CPU_NB_REGS * 2 + 25;
>> +    cc->gdb_arch_name = x86_gdb_arch_name;
>> +#ifdef TARGET_X86_64
>> +    cc->gdb_core_xml_file = "64bit-core.xml";
>> +    cc->gdb_num_core_regs = 40;
>> +#else
>> +    cc->gdb_core_xml_file = "32bit-core.xml";
>> +    cc->gdb_num_core_regs = 32;
>> +#endif
>>  #ifndef CONFIG_USER_ONLY
>>      cc->debug_excp_handler = breakpoint_handler;
>>  #endif

Since I don't know much about the GDB XML, gdb_num_core_regs used to be
41 and 57, now it's 32 and 40.  What happens to MXCSR and XMM registers?

Paolo