Re: [Qemu-devel] [Xen-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

[Anthony PERARD]

On Thu, Mar 16, 2017 at 02:06:21PM +0000, Igor Druzhinin wrote:
> On 16/03/17 12:54, Igor Druzhinin wrote:
> > On 16/03/17 12:26, Anthony PERARD wrote:
> >> I've tried to migrate a guest with this patch, but once migrated, the
> >> screen is black (via VNC, keyboard is working fine).
> >>
> > Hmm. It works for me - I've tried to migrate between identical QEMUs
> > with this patch on localhost. Save/restore also works fine.
> > 
> Ok. I could track down the issue - starting from v4 the patch doesn't
> work for cirrus. The reason is that post_load handler is different for
> cirrus and doesn't call the parent handler from common vga code.
> 
> I manage to fix it by updating the corresponding handler by duplicating
> the code. But is it a good solution? Would it be better to have the
> common handler called in this function instead?

:(, vga_common_post_load have a misleading name. Yes, I think it would
be better to have a common post_load been called by every vga cards.

-- 
Anthony PERARD