[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc: fix a qio-channel leak
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH] vnc: fix a qio-channel leak |
|
Date: |
Fri, 17 Mar 2017 10:14:04 +0000 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, Mar 17, 2017 at 01:28:02PM +0400, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> ui/vnc.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrange <address@hidden>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 8bfb1e0685..6e93b883b5 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3677,6 +3677,7 @@ static int vnc_display_listen_addr(VncDisplay *vd,
> qio_channel_set_name(QIO_CHANNEL(sioc), name);
> if (qio_channel_socket_listen_sync(
> sioc, rawaddrs[i], listenerr == NULL ? &listenerr : NULL) <
> 0) {
> + object_unref(OBJECT(sioc));
> continue;
> }
> listening = true;
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|