[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support |
Date: |
Fri, 17 Mar 2017 04:46:12 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0f16022 msi: taking interrupt format into consideration during judging a pirq
is binded with a event channel
62b6353 xen-pt: bind/unbind interrupt remapping format MSI
0900f2b Xen: add a dummy vIOMMU to create/destroy vIOMMU in Xen
7cb3e06 I440: Allow adding sysbus devices with -device on I440
=== OUTPUT BEGIN ===
Checking PATCH 1/4: I440: Allow adding sysbus devices with -device on I440...
Checking PATCH 2/4: Xen: add a dummy vIOMMU to create/destroy vIOMMU in Xen...
ERROR: trailing whitespace
#75: FILE: hw/xen/xen_viommu.c:48:
+ $
ERROR: trailing whitespace
#79: FILE: hw/xen/xen_viommu.c:52:
+ rc = xenstore_read_uint64(viommu_path, "base_addr", &s->base_addr); $
ERROR: trailing whitespace
#116: FILE: hw/xen/xen_viommu.c:89:
+ rc = xc_viommu_destroy(xen_xc, xen_domid, s->id); $
ERROR: trailing whitespace
#140: FILE: hw/xen/xen_viommu.c:113:
+ type_register_static(&xen_viommu_info); $
total: 4 errors, 0 warnings, 120 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/4: xen-pt: bind/unbind interrupt remapping format MSI...
ERROR: else should follow close brace '}'
#36: FILE: hw/xen/xen_pt_msi.c:179:
+ }
+ else {
ERROR: space prohibited after that open parenthesis '('
#54: FILE: hw/xen/xen_pt_msi.c:214:
+ if ( addr & MSI_ADDR_IM_MASK ) {
ERROR: space prohibited before that close parenthesis ')'
#54: FILE: hw/xen/xen_pt_msi.c:214:
+ if ( addr & MSI_ADDR_IM_MASK ) {
WARNING: line over 80 characters
#55: FILE: hw/xen/xen_pt_msi.c:215:
+ XEN_PT_LOG(d, "Unbinding of MSI%s . ( pirq: %d, data: %x, addr:
%lx)\n",
ERROR: line over 90 characters
#60: FILE: hw/xen/xen_pt_msi.c:220:
+ XEN_PT_ERR(d, "Unbinding of MSI%s . (error: %d, pirq: %d,
data: %x, addr: %lx)\n",
WARNING: line over 80 characters
#68: FILE: hw/xen/xen_pt_msi.c:228:
+ rc = xc_domain_unbind_msi_irq(xen_xc, xen_domid, gvec, pirq,
gflags);
ERROR: line over 90 characters
#70: FILE: hw/xen/xen_pt_msi.c:230:
+ XEN_PT_ERR(d, "Unbinding of MSI%s failed. (err: %d, pirq: %d,
gvec: %#x)\n",
total: 5 errors, 2 warnings, 61 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: msi: taking interrupt format into consideration during
judging a pirq is binded with a event channel...
ERROR: space prohibited after that open parenthesis '('
#111: FILE: xen-hvm.c:154:
+ if ( msi_addr_lo & 0x10 )
ERROR: space prohibited before that close parenthesis ')'
#111: FILE: xen-hvm.c:154:
+ if ( msi_addr_lo & 0x10 )
ERROR: braces {} are necessary for all arms of this statement
#111: FILE: xen-hvm.c:154:
+ if ( msi_addr_lo & 0x10 )
[...]
total: 3 errors, 0 warnings, 67 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [RFC PATCH 1/4] I440: Allow adding sysbus devices with -device on I440, (continued)