[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure f
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side |
|
Date: |
Fri, 17 Mar 2017 13:02:13 +0000 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
* Paolo Bonzini (address@hidden) wrote:
>
>
> On 13/03/2017 13:44, Juan Quintela wrote:
> > case RAM_SAVE_FLAG_MULTIFD_PAGE:
> > fd_num = qemu_get_be16(f);
> > - if (fd_num != 0) {
> > - /* this is yet an unused variable, changed later */
> > - fd_num = fd_num;
> > - }
> > + multifd_recv_page(host, fd_num);
> > qemu_get_buffer(f, host, TARGET_PAGE_SIZE);
> > break;
>
> I still believe this design is a mistake.
Is it a use of a separate FD carrying all of the flags/addresses that
you object to?
Dave
> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 09/16] migration: Start of multiple fd work, (continued)
[Qemu-devel] [PATCH 10/16] migration: Create ram_multifd_page, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 11/16] migration: Really use multiple pages at a time, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 12/16] migration: Send the fd number which we are going to use for this page, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 14/16] migration: Test new fd infrastructure, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 16/16] migration: Flush receive queue, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 15/16] migration: Transfer pages over new channels, Juan Quintela, 2017/03/13
Re: [Qemu-devel] [PATCH 00/16] Multifd v4, Dr. David Alan Gilbert, 2017/03/14