[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] arm: HVC and SMC encodings don't exist for
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] arm: HVC and SMC encodings don't exist for M profile |
Date: |
Mon, 20 Mar 2017 10:48:12 +0000 |
User-agent: |
mu4e 0.9.19; emacs 25.2.10 |
Peter Maydell <address@hidden> writes:
> M profile doesn't have the HVC or SMC encodings, so make them always
> UNDEF rather than generating calls to helper functions that assume
> A/R profile.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/arm/translate.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 9fded03..895b399 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -10365,6 +10365,9 @@ static int disas_thumb2_insn(CPUARMState *env,
> DisasContext *s, uint16_t insn_hw
> goto illegal_op;
>
> if (insn & (1 << 26)) {
> + if (arm_dc_feature(s, ARM_FEATURE_M)) {
> + goto illegal_op;
> + }
> if (!(insn & (1 << 20))) {
> /* Hypervisor call (v7) */
> int imm16 = extract32(insn, 16, 4) << 12
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 1/4] arm: HVC and SMC encodings don't exist for M profile,
Alex Bennée <=