Re: [Qemu-devel] [PATCH 01/31] ram: move more fields into RAMState

[Juan Quintela]

"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> last_seen_block, last_sent_block, last_offset, last_version and
>> ram_bulk_stage are globals that are really related together.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>>  migration/ram.c | 136 
>> ++++++++++++++++++++++++++++++++------------------------
>>  1 file changed, 79 insertions(+), 57 deletions(-)
>> 
>> diff --git a/migration/ram.c b/migration/ram.c
>> index 719425b..c20a539 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -136,6 +136,23 @@ out:
>>      return ret;
>>  }
>>  
>> +/* State of RAM for migration */
>> +struct RAMState {
>> +    /* Last block that we have visited searching for dirty pages */
>> +    RAMBlock    *last_seen_block;
>> +    /* Last block from where we have sent data */
>> +    RAMBlock *last_sent_block;
>> +    /* Last offeset we have sent data from */
>                   ^
>                   One extra e
>
> Other than that (and the minor formatting things the bot found)

fixed, thanks.

>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>