[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs: don't try to flush self and avoid QEMU ha
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs: don't try to flush self and avoid QEMU hang on reset |
|
Date: |
Tue, 21 Mar 2017 10:42:08 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/21/2017 09:42 AM, Greg Kurz wrote:
>>> This insane behavior is likely to denote a bug in the client, and it would
>>> deserve an Rerror message to be sent back. Unfortunately, the protocol
>>> allows it and requires all flush requests to suceed (only a Tflush response
>>>
>>
>> s/suceed/succeed/
The pull request still has the typo,
>>
>> Reviewed-by: Eric Blake <address@hidden>
>>
>
> Oh, I've sent a v2 for this patch (error_report() a warning) and it is
> actually part of the pull request I've sent earlier today... dunno how
> to have your Reviewed-by: added there.
If you really want it, send a v2 pull request before Peter merges v1
(and an explicit NACK on the v1 cover letter will make your intentions
clear). But at this point, I'm fine if the v1 pull request goes in
untouched.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature