Re: [Qemu-devel] [PATCH v2] numa, spapr: align default numa node memory size to 256MB

[Eduardo Habkost]

On Tue, Mar 21, 2017 at 12:03:21PM +1100, David Gibson wrote:
> On Mon, Mar 20, 2017 at 04:11:14PM -0300, Eduardo Habkost wrote:
> > On Mon, Mar 20, 2017 at 03:12:44PM +0100, Laurent Vivier wrote:
> > > Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node
> > > memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE).
> > > 
> > > But when "-numa" option is provided without "mem" parameter,
> > > the memory is equally divided between nodes, but 8MB aligned.
> > > This can be not valid for pseries.
> > > 
> > > In that case we can have:
> > > $ ./ppc64-softmmu/qemu-system-ppc64 -m 4G -numa node -numa node -numa node
> > > qemu-system-ppc64: Node 0 memory size 0x55000000 is not aligned to 256 MiB
> > > 
> > > With this patch, we have:
> > > (qemu) info numa
> > > 3 nodes
> > > node 0 cpus: 0
> > > node 0 size: 1280 MB
> > > node 1 cpus:
> > > node 1 size: 1280 MB
> > > node 2 cpus:
> > > node 2 size: 1536 MB
> > > 
> > > Signed-off-by: Laurent Vivier <address@hidden>
> 
> In agree with Eduardo's suggested comment changes.  Apart from that,
> 
> Reviewed-by: David Gibson <address@hidden>
> 
> Eduardo, do you want to take the final spin through your tree, or
> should I take it through mine?

As the bug affects only spapr, please feel free to merge it.

Acked-by: Eduardo Habkost <address@hidden>

-- 
Eduardo