[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts |
|
Date: |
Wed, 22 Mar 2017 12:39:29 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/22/2017 12:35 PM, address@hidden wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Type: series
> Subject: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in
> user_creatable_add_opts
> Message-id: address@hidden
>
> /var/tmp/patchew-tester-tmp-5drz5kus/src/qom/object_interfaces.c: In function
> ‘user_creatable_add_opts’:
> /var/tmp/patchew-tester-tmp-5drz5kus/src/qom/object_interfaces.c:125:16:
> error: passing argument 1 of ‘g_free’ discards ‘const’ qualifier from pointer
> target type [-Werror=discarded-qualifiers]
> g_free(type);
> ^~~~
Silly patchew. Maybe we should teach you that any patch with 'fixup!' in
the title is _probably_ not going to compile on its own, because it is a
fixup to be sqaushed to an (as-yet) uncommitted patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature