qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL for-2.9 2/2] cryptodev: fix asserting single queue


From: Gonglei
Subject: [Qemu-devel] [PULL for-2.9 2/2] cryptodev: fix asserting single queue
Date: Thu, 23 Mar 2017 17:39:11 +0800

From: Halil Pasic <address@hidden>

We already check for queues == 1 in cryptodev_builtin_init and when that
is not true raise an error. But before that error is reported the
assertion in cryptodev_builtin_cleanup kicks in (because object is being
finalized and freed).

Let's remove assert(queues == 1) form cryptodev_builtin_cleanup as it
does only harm and no good.

Reported-by: Boris Fiuczynski <address@hidden>
Signed-off-by: Halil Pasic <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Gonglei <address@hidden>
---
 backends/cryptodev-builtin.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
index b24a299..657c0ba 100644
--- a/backends/cryptodev-builtin.c
+++ b/backends/cryptodev-builtin.c
@@ -361,8 +361,6 @@ static void cryptodev_builtin_cleanup(
         }
     }
 
-    assert(queues == 1);
-
     for (i = 0; i < queues; i++) {
         cc = backend->conf.peers.ccs[i];
         if (cc) {
-- 
1.7.12.4





reply via email to

[Prev in Thread] Current Thread [Next in Thread]