Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

[Dong Jia Shi]

* Sebastian Ott <address@hidden> [2017-03-23 12:51:40 +0100]:

> On Fri, 17 Mar 2017, Dong Jia Shi wrote:
> > For future code reuse purpose, this decouples the cio code with
> > the ccw device specific parts from ccw_device_cancel_halt_clear,
> > and makes a new common I/O interface named cio_cancel_halt_clear.
> > 
> > Reviewed-by: Pierre Morel <address@hidden>
> > Signed-off-by: Dong Jia Shi <address@hidden>
> > Cc: Sebastian Ott <address@hidden>
> > Cc: Peter Oberparleiter <address@hidden>
> [...]
> > +/**
> > + * cio_cancel_halt_clear - Cancel running I/O by performing cancel, halt
> > + * and clear ordinally if subchannel is valid.
> > + * @sch: subchannel on which to perform the cancel_halt_clear operation
> > + * @iretry: the number of the times remained to retry the next operation
> > + *
> > + * This should be called repeatedly since halt/clear are asynchronous
> > + * operations. We do one try with cio_cancel, two tries with cio_halt,
>                                                  ^
>                                                  three
Ok. Nice catch!

> 
> Acked-by: Sebastian Ott <address@hidden>
Thanks.

-- 
Dong Jia Shi