[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbu
From: |
Juergen Gross |
Subject: |
Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class |
Date: |
Fri, 24 Mar 2017 11:24:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 24/03/17 11:09, Peter Maydell wrote:
> On 24 March 2017 at 08:23, Juergen Gross <address@hidden> wrote:
>> On 23/03/17 22:28, Eduardo Habkost wrote:
>>> The xen-backend devices created by the Xen code are not supposed
>>> to be treated as dynamic sysbus devices. This is an attempt to
>>> change that and see what happens, but I couldn't test it because
>>> I don't have a Xen host set up.
>>>
>>> If this patch breaks anything, this means we have a bug in
>>> foreach_dynamic_sysbus_device(), which is supposed to return only
>>> devices created using -device.
>>>
>>> The original code that sets has_dynamic_sysbus was added by
>>> commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894, but I don't see
>>> any comment explaining why it was necessary.
>>
>> xen-backend devices are created via qmp commands when attaching new
>> pv-devices to a domain. They can be dynamically removed, too. Setting
>> has_dynamic_sysbus was necessary to support this feature.
>
> This seems like it ought to be handled by marking the xen-backend
> devices as being ok-to-dynamically-create somehow, not by marking
> the machine as supporting dynamic-sysbus (which it doesn't).
> Maybe we don't have the necessary support code to do that though?
When writing the patches I couldn't find a way to do it differently.
OTOH I'm not so deep in qemu internals I'd be able to add the needed
support.
I'd be happy to test any patch, though.
Juergen
- [Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type whitelist, Eduardo Habkost, 2017/03/23
- [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class, Eduardo Habkost, 2017/03/23
- Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class, Juergen Gross, 2017/03/24
- Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class, Peter Maydell, 2017/03/24
- Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class,
Juergen Gross <=
- Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class, Eduardo Habkost, 2017/03/24
- Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class, Juergen Gross, 2017/03/24
- Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class, Eduardo Habkost, 2017/03/24
- Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class, Juergen Gross, 2017/03/24
- Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class, Thomas Huth, 2017/03/24
[Qemu-devel] [RFC 2/4] machine: Replace has_dynamic_sysbus with a whitelist, Eduardo Habkost, 2017/03/23
[Qemu-devel] [RFC 3/4] q35: Remove ioapic devices from sysbus whitelist, Eduardo Habkost, 2017/03/23
[Qemu-devel] [RFC 4/4] q35: Remove fw_cfg* from sysbus whitelist, Eduardo Habkost, 2017/03/23
Re: [Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type whitelist, Juergen Gross, 2017/03/24