[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous com
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit |
Date: |
Fri, 24 Mar 2017 13:44:12 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/24/2017 12:44 PM, Markus Armbruster wrote:
> This code in qemu_rbd_parse_filename()
>
> found_str = qemu_rbd_next_tok(p, '\0', &p);
This says to take a string starting at p, modify it in place, update p
to point past the delimiter (well, to nowhere since the delimiter of
'\0' means it is the last token parsed), and return the original
starting into found_str....
> p = found_str;
...and this says to revert the change to p (why we had to pass &p
instead of NULL is beyond me). Furthermore, reading the modifications
that qemu_rbd_next_tok() does in place (namely, looking for \ escape
sequences), it doesn't do any when delimiter is '\0'. Prior to patch 3,
it was therefore useful as an idiom for length checking - but as you
killed even that aspect, I agree with your assessment that it is now a
no-op.
>
> has no effect. Drop it, and simplify qemu_rbd_next_tok().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/rbd.c | 24 +++++++++---------------
> 1 file changed, 9 insertions(+), 15 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC v2 0/9] rbd: Clean up API and code, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 2/9] rbd: Fix to cleanly reject -drive without pool or image, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit, Markus Armbruster, 2017/03/24
- Re: [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit,
Eric Blake <=
- [Qemu-devel] [PATCH RFC v2 9/9] rbd: Reject invalid authentication methods, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 7/9] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 8/9] rbd: Rewrite the code to extract list-valued options, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 3/9] rbd: Don't limit length of parameter values, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 5/9] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=..., Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 6/9] rbd: Clean up runtime_opts, fix -drive to reject filename, Markus Armbruster, 2017/03/24