[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 for-2.9 05/11] rbd: Don't accept -drive d
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 for-2.9 05/11] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=... |
Date: |
Mon, 27 Mar 2017 20:26:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Max Reitz <address@hidden> writes:
> On 27.03.2017 15:26, Markus Armbruster wrote:
>> The way we communicate extra key-value pairs from
>> qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter
>> "keyvalue-pairs" on the command line. It's not wanted there. Hack:
>> rename the parameter to "=keyvalue-pairs" to make it inaccessible.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>> block/rbd.c | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> Reviewed-by: Max Reitz <address@hidden>
Thanks!
> (Or you could just use x- like blkdebug does...)
Yes.
An "x-" prefix tells you "don't use this", which you're free to ignore.
The "=" prefix cannot be ignored, because the QemuOpts parser will
choke on it.
Matter of taste, I guess.
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret, (continued)
[Qemu-devel] [PATCH RFC v3 for-2.9 01/11] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Markus Armbruster, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 01/11] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Max Reitz, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 01/11] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Jeff Cody, 2017/03/27
[Qemu-devel] [PATCH RFC v3 for-2.9 05/11] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=..., Markus Armbruster, 2017/03/27
[Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Markus Armbruster, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Max Reitz, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Max Reitz, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Markus Armbruster, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Markus Armbruster, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Jeff Cody, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Markus Armbruster, 2017/03/28
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Jeff Cody, 2017/03/28
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Jeff Cody, 2017/03/28