[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev para
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret |
Date: |
Tue, 28 Mar 2017 09:58:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Jeff Cody <address@hidden> writes:
> On Mon, Mar 27, 2017 at 10:32:40PM -0400, Jeff Cody wrote:
>> On Mon, Mar 27, 2017 at 03:26:33PM +0200, Markus Armbruster wrote:
>> > This reverts a part of commit 8a47e8e. We're having second thoughts
>> > on the QAPI schema (and thus the external interface), and haven't
>> > reached consensus, yet. Issues include:
>> >
>> > * BlockdevOptionsRbd member @password-secret isn't actually a
>> > password, it's a key generated by Ceph.
>> >
>> > * We're not sure where member @password-secret belongs (see the
>> > previous commit).
>> >
>> > * How @password-secret interacts with settings from a configuration
>> > file specified with @conf is undocumented. I suspect it's untested,
>> > too.
>>
>> It's tested, at least to some extent -- it works on my setup; it will
>> override whatever is set in the conf or the keyring. I can alternate
>> between /etc/ceph/keyring, or password-secret, or override the user present
>> in /etc/cep/keyring with a different key via password-secret.
>>
>> So I'd suggest dropping that blurb from the commit message.
Of course.
>> I agree with the overall reasoning though behind remove all parameters not
>> needed for now, so:
>>
>> Reviewed-by: Jeff Cody <address@hidden>
>>
>
> Wait, hold up on that R-b :)
>
> This only seems to revert the comment in the QAPI. You meant to remove the
> entry from the BlockdevOptionsRbd struct too, right?
D'oh! Suspect a rebase accident... I'll drop the member and keep your
R-by.
- [Qemu-devel] [PATCH RFC v3 for-2.9 07/11] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts, (continued)
- [Qemu-devel] [PATCH RFC v3 for-2.9 01/11] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Markus Armbruster, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 01/11] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Max Reitz, 2017/03/27
- Re: [Qemu-devel] [PATCH RFC v3 for-2.9 01/11] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Jeff Cody, 2017/03/27
- [Qemu-devel] [PATCH RFC v3 for-2.9 05/11] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=..., Markus Armbruster, 2017/03/27
- [Qemu-devel] [PATCH RFC v3 for-2.9 02/11] rbd: Fix to cleanly reject -drive without pool or image, Markus Armbruster, 2017/03/27