Re: [Qemu-devel] [PATCH RFC v3 for-2.9 03/11] rbd: Don't limit length of parameter values

[Markus Armbruster]

Jeff Cody <address@hidden> writes:

> On Mon, Mar 27, 2017 at 03:26:27PM +0200, Markus Armbruster wrote:
>> We laboriously enforce parameter values are between one and some
>
> s/are/that are/
>
> or maybe just s/are//

What about:

   We laboriously enforce that parameter values are between one and some

>> arbitrary limit in length.  Only RBD_MAX_IMAGE_NAME_SIZE comes from
>> librbd.h, and I'm not sure it applies.  Where the other limits come
>> from is unclear.
>> 
>> Drop the length checking.  The limits librbd actually imposes must be
>> checked by librbd anyway.
>> 
>> There's one minor complication: BDRVRBDState member name is a
>> fixed-size array.  Depends on the length limit.  Make it a pointer to
>> a dynamically allocated string.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>
> Reviewed-by: Jeff Cody <address@hidden>

Thanks!