[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] vfio pci: new function to init AER capab
From: |
Cao jin |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] vfio pci: new function to init AER capability |
Date: |
Tue, 28 Mar 2017 21:47:49 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 03/25/2017 06:12 AM, Alex Williamson wrote:
> On Thu, 23 Mar 2017 17:09:22 +0800
> Cao jin <address@hidden> wrote:
>
> This is not a sufficiently trivial patch to leave the commit log empty.
>
>> Signed-off-by: Dou Liyang <address@hidden>
>> Signed-off-by: Cao jin <address@hidden>
>> ---
>> + pcie_cap_deverr_init(pdev);
>
> This assumes we've set exp_cap, perhaps the code should validate this
> to avoid corner case configurations where the PCIe cap has been dropped
> yet AER is still present. I'm not sure if it's possible, but I'd
> rather test than segfault.
>
>> + return pcie_aer_init(pdev, cap_ver, pos, size, errp);
>
>
> I think here too, users may have existing configurations that could
> break by suddenly imposing a new topology requirement.
>
Not quite follow, test what for pcie_aer_init()?
--
Sincerely,
Cao jin
Re: [Qemu-devel] [PATCH v3 0/3] vfio-pci: support recovery of AER non fatal error, Alex Williamson, 2017/03/24