Re: [Qemu-devel] [PATCH 1/6] migration/announce: Add parameters for self-announce

[Eric Blake]

On 03/28/2017 10:27 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> Add the parameters and wire into the set/get routines.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  migration/migration.c | 52 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  qapi-schema.json      | 34 +++++++++++++++++++++++++++++++--
>  2 files changed, 84 insertions(+), 2 deletions(-)
> 

>  
> +    if (params->has_announce_initial &&
> +        (params->announce_initial < 1 || params->announce_initial > 100000)) 
> {
> +        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "announce_initial",
> +                   "is invalid, it should be in the range of 1 to 100000 
> ms");
> +    }
> +    if (params->has_announce_max &&
> +        (params->announce_max < 1 || params->announce_max > 100000)) {

You're doing range validation here...

> +++ b/qapi-schema.json
> @@ -960,6 +960,18 @@
>  #
>  # Migration parameters enumeration
>  #
> +# @announce-initial: The inital delay (in ms) before sending the first 
> announce
> +#          (Since 2.10)

...so it would be useful to mention the bounds here. Also, mentioning
the defaults is a good idea.

s/inital/initial/

> +#
> +# @announce-max: The maximum delay (in ms) between packets in the announcment
> +#          (Since 2.10)

s/announcment/announcement/

> +#
> +# @announce-rounds: The number of self-announce packets sent after migration
> +#          (Since 2.10)
> +#
> +# @announce-step: The increase in delay (in ms) between subsequent packets in
> +#          the announcement (Since 2.10)
> +#

> @@ -1038,6 +1052,18 @@
>  # ('query-migrate-parameters'), with the exception of tls-creds and
>  # tls-hostname.
>  #
> +# @announce-initial: The inital delay (in ms) before sending the first 
> announce
> +#          (Since 2.10)
> +#
> +# @announce-max: The maximum delay (in ms) between packets in the announcment
> +#          (Since 2.10)

same two typos

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature