Re: [Qemu-devel] [for-2.9 1/8] nbd sockets vnc: Mark problematic address family tests TODO

[Max Reitz]

On 29.03.2017 18:45, Markus Armbruster wrote:
> Certain features make sense only with certain address families.  For
> instance, passing file descriptors requires AF_UNIX.  Testing
> SocketAddress's saddr->type == SOCKET_ADDRESS_KIND_UNIX is obvious,
> but problematic: it can't recognize AF_UNIX when type ==
> SOCKET_ADDRESS_KIND_FD.
> 
> Mark such tests of saddr->type TODO.  We may want to check the address
> family with getsockname() there.
> 
> Cc: Paolo Bonzini <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Daniel P. Berrange <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block/nbd.c           | 1 +
>  blockdev-nbd.c        | 1 +
>  chardev/char-socket.c | 5 ++---
>  ui/vnc.c              | 1 +
>  util/qemu-sockets.c   | 4 ++++
>  5 files changed, 9 insertions(+), 3 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature