Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

[Juan Quintela]

"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> We change the meaning of start to be the offset from the beggining of
>> the block.
>
> s/beggining/beginning/
>
> Why do this?
> We have:
>    migration_bitmap_sync (all blocks)
>    migration_bitmap_sync_range - called per block
>    cpu_physical_memory_sync_dirty_bitmap
>
> Why keep migration_bitmap_sync_range having start/length as well as the block
> if you could just rename it to migration_bitmap_sync_block and just give it 
> the rb?
> And since cpu_physical_memory_clear_dirty_range is lower level, why give it
> the rb?

I did it on the previous series, then I remembered that I was not going
to be able to sync only part of the range, as I will want in the future.

If you preffer as an intermediate meassure to just move to blocks, I can
do, but change is really small and not sure if it makes sense.


Later, Juan.