[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch
From: |
Richard W.M. Jones |
Subject: |
Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch |
Date: |
Fri, 31 Mar 2017 18:31:01 +0100 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Fri, Mar 31, 2017 at 06:53:56PM +0200, Paolo Bonzini wrote:
> glib is expecting QEMU to use g_main_context_acquire around accesses to
> GMainContext. However QEMU is not doing that, instead it is taking its
> own mutex. So we should add g_main_context_acquire and
> g_main_context_release in the two implementations of
> os_host_main_loop_wait; these should undo the effect of Frediano's
> glib patch.
Based on this paragraph, I'm testing the attached patch, and it does
also appear to solve the hanging serial port problem.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
0001-main-loop-Acquire-main_context-lock-around-os_host_m.patch
Description: Text document