[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch |
Date: |
Sat, 1 Apr 2017 12:08:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 31/03/2017 19:31, Richard W.M. Jones wrote:
> On Fri, Mar 31, 2017 at 06:53:56PM +0200, Paolo Bonzini wrote:
>> glib is expecting QEMU to use g_main_context_acquire around accesses to
>> GMainContext. However QEMU is not doing that, instead it is taking its
>> own mutex. So we should add g_main_context_acquire and
>> g_main_context_release in the two implementations of
>> os_host_main_loop_wait; these should undo the effect of Frediano's
>> glib patch.
>
> Based on this paragraph, I'm testing the attached patch, and it does
> also appear to solve the hanging serial port problem.
Turn out that it may actually be a glib bug. Your patch would enable
Frediano's optimizations so it's worth applying anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=761102
Paolo
- Re: [Qemu-devel] [PATCH] char: kick main loop after adding a watch,
Paolo Bonzini <=