[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] migration: Fix colo hang in socket_accept_in
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v2] migration: Fix colo hang in socket_accept_incoming_migration |
Date: |
Mon, 3 Apr 2017 12:04:35 +0100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, Mar 24, 2017 at 09:04:49AM +0800, Guang Wang wrote:
> From: Wang guang <address@hidden>
>
> The channel socket was initialized manually,
> but forgot to set QIO_CHANNEL_FEATURE_SHUTDOWN.
> Thus, the colo_process_incoming_thread would hang at recvmsg.
> This patch just call qio_channel_socket_new to get channel,
> Which set QIO_CHANNEL_FEATURE_SHUTDOWN already.
>
> Signed-off-by: Wang Guang<address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> io/channel-socket.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
Looks good to me - I'll try to get this into 2.9
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2] migration: Fix colo hang in socket_accept_incoming_migration,
Daniel P. Berrange <=