[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 15/21] esp: Remove user_creatable flag
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH v2 15/21] esp: Remove user_creatable flag |
Date: |
Tue, 4 Apr 2017 17:24:23 -0300 |
esp devices aren't going to work with -device, as they need IRQs
to be connected and mmio to be mapped (this is done by
esp_init()). Remove the user_creatable flag from the device
class.
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
Changes v1 -> v2:
* Commit message rewrite only
---
hw/scsi/esp.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index 7bdc1e1b99..eee831efeb 100644
--- a/hw/scsi/esp.c
+++ b/hw/scsi/esp.c
@@ -728,11 +728,6 @@ static void sysbus_esp_class_init(ObjectClass *klass, void
*data)
dc->reset = sysbus_esp_hard_reset;
dc->vmsd = &vmstate_sysbus_esp_scsi;
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
static const TypeInfo sysbus_esp_info = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [PATCH v2 06/21] pflash_cfi01: Remove user_creatable flag, (continued)
- [Qemu-devel] [PATCH v2 06/21] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 07/21] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 08/21] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 09/21] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 12/21] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 11/21] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 10/21] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 13/21] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 14/21] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 15/21] esp: Remove user_creatable flag,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v2 16/21] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 17/21] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 18/21] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 19/21] virtio-mmio: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 20/21] xen-sysdev: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 21/21] s390-pcibus: No need to set user_creatable=false explicitly, Eduardo Habkost, 2017/04/04
- Re: [Qemu-devel] [PATCH v2 00/21] qdev/sysbus: Set user_creatable=false by default on sysbus, Marcel Apfelbaum, 2017/04/06