qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 12/12] replay: assert time only goes forward


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH v2 12/12] replay: assert time only goes forward
Date: Wed, 05 Apr 2017 15:37:05 +0100
User-agent: mu4e 0.9.19; emacs 25.2.13

Paolo Bonzini <address@hidden> writes:

> On 05/04/2017 15:33, Pavel Dovgalyuk wrote:
>>> +
>>> +        /* Time can only go forward */
>>> +        assert(diff >= 0);
>>> +
>>>          if (diff > 0) {
>> This "if" is useless then.
>>
>
> It isn't, "diff == 0" can happen.

In my previous patchset I actually output-ed a EVENT_INSTRUCTION with a
zero diff for the negative case although it does seem redundant to
output that if we can avoid it?

--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]