qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/21] ppc/pnv: enable only one LPC bus


From: Cédric Le Goater
Subject: Re: [Qemu-devel] [PATCH 04/21] ppc/pnv: enable only one LPC bus
Date: Thu, 6 Apr 2017 13:50:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 04/06/2017 11:16 AM, Benjamin Herrenschmidt wrote:
> On Thu, 2017-04-06 at 11:06 +0200, Cédric Le Goater wrote:
>> The object will be initialized which raises some concern because we don't 
>> have the chip id at the moment but the object is still valid in some way. 
>> I think I need to remove it from the list of children of the chip or use 
>> a pointer instead.
> 
> Well... so it exists on all chips. All chips have an LPC controller...
> 
> Whether firmware enables it and whether it's connected to anything is a
>  system issue.

So, looking at hostboot, the lower level firmware, I think the initial 
patch is more in sync with it : 

   
https://github.com/open-power/hostboot/blob/master-p8/src/usr/devtree/bld_devtree.C#L1038

David, can we keep it as it is ? I will change the commit log which is 
a bit fuzzy. 

Cheers,

C. 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]