qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/21] ppc/pnv: enable only one LPC bus


From: Cédric Le Goater
Subject: Re: [Qemu-devel] [PATCH 04/21] ppc/pnv: enable only one LPC bus
Date: Thu, 6 Apr 2017 14:35:57 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 04/06/2017 02:01 PM, Benjamin Herrenschmidt wrote:
> On Thu, 2017-04-06 at 13:50 +0200, Cédric Le Goater wrote:
>>
>> So, looking at hostboot, the lower level firmware, I think the
>> initial 
>> patch is more in sync with it : 
>>
>>    https://github.com/open-power/hostboot/blob/master-p8/src/usr/devt
>> ree/bld_devtree.C#L1038
>>
>> David, can we keep it as it is ? I will change the commit log which
>> is a bit fuzzy. 
> 
> Note that OPAL should be happy to have multiple LPCs in the DT as long
> as one of them has the "primary" property in the node to tell it that's
> where the UART etc... are.

yes, that works also : 

[    0.024439731,5] LPC: LPC[000]: Initialized, access via XSCOM @0xb0020
[    0.024499074,5] LPC: LPC[001]: Initialized, access via XSCOM @0xb0020
[    0.024517962,5] LPC: LPC: Default bus on chip 0x0

but real HW (2 sockets OpenPOWER systems, garrison and firestone) does 
not expose the LPC bus on the second chip, should we do so in qemu ? 

Thanks,

C. 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]