[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/13] block: Simplify bdrv_append_temp_snaps
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/13] block: Simplify bdrv_append_temp_snapshot() logic |
Date: |
Thu, 6 Apr 2017 08:22:51 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/06/2017 07:52 AM, Eric Blake wrote:
>>> +out:
>>> + QDECREF(snapshot_options);
>>> g_free(tmp_filename);
>>> return bs_snapshot;
>>
>> bs_snapshot is uninitialised or at least the wrong return value in error
>> cases. (Hm... Shouldn't the compiler catch the uninitialised part?)
>
> Odd, and I agree that I recall the compiler generally able to catch that
> (maybe it's a matter of compiling with -g vs. -O2). I'm surprised the
> autobuilder didn't flag it.
And now the autobuilder finally replies. It is indeed a matter of
difference in CFLAGS on whether the compiler will catch it.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 06/13] qobject: Add helper macros for common scalar insertions, (continued)
- [Qemu-devel] [PATCH v3 06/13] qobject: Add helper macros for common scalar insertions, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 05/13] qobject: Drop useless QObject casts, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 08/13] tests: Use simpler QDict/QList scalar insertion macros, Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 11/13] QemuOpts: Simplify qemu_opts_to_qdict(), Eric Blake, 2017/04/05
- [Qemu-devel] [PATCH v3 10/13] block: Simplify bdrv_append_temp_snapshot() logic, Eric Blake, 2017/04/05
[Qemu-devel] [PATCH v3 07/13] block: Use simpler QDict/QList scalar insertion macros, Eric Blake, 2017/04/05
[Qemu-devel] [PATCH v3 13/13] test-qga: Actually test 0xff sync bytes, Eric Blake, 2017/04/05
[Qemu-devel] [PATCH v3 12/13] fdc-test: Avoid deprecated 'change' command, Eric Blake, 2017/04/05
[Qemu-devel] [PATCH v3 09/13] qobject: Use simpler QDict/QList scalar insertion macros, Eric Blake, 2017/04/05