[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] esp-pci: simple clean up
|
From: |
Sahid Orentino Ferdjaoui |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] esp-pci: simple clean up |
|
Date: |
Fri, 7 Apr 2017 10:49:31 +0200 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Fri, Apr 07, 2017 at 02:59:08PM +0800, weiqi wrote:
> From: Wei Qi <address@hidden>
>
> It is unnecessary to assign variable 'size' here, because 'size' unused after
> assignment.
>
> Signed-off-by: Wei Qi <address@hidden>
> ---
> hw/scsi/esp-pci.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-By: Sahid Orentino Ferdjaoui <address@hidden>
>
> diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
> index e295d88..1f5980e 100644
> --- a/hw/scsi/esp-pci.c
> +++ b/hw/scsi/esp-pci.c
> @@ -192,7 +192,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
> val <<= shift;
> val |= current & ~(mask << shift);
> addr &= ~3;
> - size = 4;
I verified that 'size' is passed by value to 'esp_pci_io_write(...)',
no loop, no recursivity.
> }
>
> if (addr < 0x40) {
> --
> 1.8.3.1
>
>