[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/10] block: Don't check permissions for copy on rea
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 07/10] block: Don't check permissions for copy on read |
Date: |
Fri, 7 Apr 2017 15:47:42 +0200 |
The assertion is currently failing. We can't require callers to have
write permissions when all they are doing is a read, so comment it out.
Add a FIXME comment in the code so that the check is re-enabled when
copy on read is refactored into its own filter driver.
Reported-by: Richard W.M. Jones <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Richard W.M. Jones <address@hidden>
---
block/io.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index 2709a70..7321dda 100644
--- a/block/io.c
+++ b/block/io.c
@@ -945,7 +945,14 @@ static int coroutine_fn bdrv_co_do_copy_on_readv(BdrvChild
*child,
size_t skip_bytes;
int ret;
- assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));
+ /* FIXME We cannot require callers to have write permissions when all they
+ * are doing is a read request. If we did things right, write permissions
+ * would be obtained anyway, but internally by the copy-on-read code. As
+ * long as it is implemented here rather than in a separat filter driver,
+ * the copy-on-read code doesn't have its own BdrvChild, however, for which
+ * it could request permissions. Therefore we have to bypass the permission
+ * system for the moment. */
+ // assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));
/* Cover entire cluster so no additional backing file I/O is required when
* allocating cluster in the image file.
--
1.8.3.1
- [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 03/10] commit: Set commit_top_bs->total_sectors, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 02/10] commit: Set commit_top_bs->aio_context, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 01/10] block: Ignore guest dev permissions during incoming migration, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 04/10] block/mirror: Fix use-after-free, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 05/10] iotests: Add mirror tests for orphaned source, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 06/10] qemu-img: img_create does not support image-opts, fix docs, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 10/10] mirror: Fix aio context of mirror_top_bs, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 07/10] block: Don't check permissions for copy on read,
Kevin Wolf <=
- [Qemu-devel] [PULL 08/10] block: Fix unpaired aio_disable_external in external snapshot, Kevin Wolf, 2017/04/07
- [Qemu-devel] [PULL 09/10] block: Assert attached child node has right aio context, Kevin Wolf, 2017/04/07
- Re: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4, Peter Maydell, 2017/04/07
- Re: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4, no-reply, 2017/04/12