[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] blockjob: introduce block_job_fail
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/10] blockjob: introduce block_job_fail |
|
Date: |
Mon, 10 Apr 2017 10:22:55 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Mar 23, 2017 at 06:39:21PM +0100, Paolo Bonzini wrote:
> Outside blockjob.c, block_job_unref is only used when a block job fails
> to start, and block_job_ref is not used at all. The reference counting
> thus is pretty well hidden. Introduce a separate function to be used
> by block jobs; because block_job_ref and block_job_unref now become
> static, move them earlier in blockjob.c.
>
> Later on, block_job_fail will also have different locking than
> block_job_unref.
block_job_fail() sounds like it's *the* job failure API.
How about block_job_fail_early()?
It indicates the API is only for the beginning of the job's lifecycle.
Stefan
signature.asc
Description: PGP signature