Re: [Qemu-devel] [PATCH for-2.10 15/19] tests: crypto: add cipher speed case

[Longpeng (Mike)]

Hi Daniel,

Ok, I'll take all your suggestions, and fix them in next version.

Thanks.

On 2017/4/10 17:51, Daniel P. Berrange wrote:

> On Mon, Apr 10, 2017 at 05:00:58PM +0800, Longpeng(Mike) wrote:
>> Now we have afalg-backend and libiary-backend, it's necessary
>> to add the speed test in test-crypto-cipher.
>>
>> We can use "./tests/test-crypto-cipher speed" to do the speed
>> test.
> 
> This is not using any of the existing code for the benchmark, so there's
> no real benefit to having it in this file.
> 
> I'd suggest creating a separate test program for performance benchmarking,
> eg  tests/benchmark-crypto-cipher, that would be invoked separately as &
> when needed ie skipped by make check-unit, but run by a 'make check-speed'.
> 
> Likewise for the other tests you've changed later in this series.
> 
> 
> Regards,
> Daniel


-- 
Regards,
Longpeng(Mike)