[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/11] cpus: remove icount handling from qemu_tcg_cpu
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 04/11] cpus: remove icount handling from qemu_tcg_cpu_thread_fn |
Date: |
Mon, 10 Apr 2017 13:55:17 +0100 |
We should never be running in multi-threaded mode with icount enabled.
There is no point calling handle_icount_deadline here so remove it and
assert !use_icount.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
diff --git a/cpus.c b/cpus.c
index 58d90aa2b9..fc0ddc8793 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1392,6 +1392,8 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
{
CPUState *cpu = arg;
+ g_assert(!use_icount);
+
rcu_register_thread();
qemu_mutex_lock_iothread();
@@ -1434,8 +1436,6 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
}
}
- handle_icount_deadline();
-
atomic_mb_set(&cpu->exit_request, 0);
qemu_tcg_wait_io_event(cpu);
}
--
2.11.0
- [Qemu-devel] [PULL 00/11] Final icount and misc MTTCG fixes for 2.9, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 04/11] cpus: remove icount handling from qemu_tcg_cpu_thread_fn,
Alex Bennée <=
- [Qemu-devel] [PULL 02/11] cpus: fix wrong define name, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 05/11] cpus: check cpu->running in cpu_get_icount_raw(), Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 06/11] cpus: move icount preparation out of tcg_exec_cpu, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 03/11] target/i386/misc_helper: wrap BQL around another IRQ generator, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 01/11] scripts/qemugdb/mtree.py: fix up mtree dump, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 10/11] cpus: call cpu_update_icount on read, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 08/11] cpus: introduce cpu_update_icount helper, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 11/11] replay: assert time only goes forward, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 09/11] cpu-exec: update icount after each TB_EXIT, Alex Bennée, 2017/04/10
- [Qemu-devel] [PULL 07/11] cpus: don't credit executed instructions before they have run, Alex Bennée, 2017/04/10