Re: [Qemu-devel] [PATCH] event: Add signal information to SHUTDOWN

[Daniel P. Berrange]

On Wed, Apr 12, 2017 at 01:02:02PM +0200, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
> > qemu_kill_report() is already able to tell whether a shutdown
> > was triggered by guest action (no output) or by a host signal
> > (a message about termination is printed via error_report); but
> > this information is then lost.  Libvirt would like to be able
> > to distinguish between a SHUTDOWN event triggered solely by
> > guest request and one triggered by a SIGTERM on the host.
> >
> > Enhance the SHUTDOWN event to pass the value of shutdown_signal
> > through to the monitor client, suitably remapped into a
> > platform-neutral string.  Note that mingw lacks decent signal
> 
> I understand the desire to distinguish between guest-initiated and
> host-initiated shutdown, but I'm not sure why libvirt (or anyone) would
> care for the exact signal.  Can you explain?

Libvirt doesn't care from a functional POV - it merely needs to distinguish
host vs guest. Any signal info would merely informational and thus logged.
So signal info would realistically only be used someone is trying to
troubleshoot some problem and needs to understand exactly what triggered
it.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|