Re: [Qemu-devel] [PATCH v6] Allow setting NUMA distance for different NUMA nodes

[He Chen]

On Tue, Apr 11, 2017 at 08:18:49AM -0500, Eric Blake wrote:
> On 04/11/2017 03:49 AM, He Chen wrote:
> > This patch is going to add SLIT table support in QEMU, and provides
> > additional option `dist` for command `-numa` to allow user set vNUMA
> > distance by QEMU command.
> > 
> > With this patch, when a user wants to create a guest that contains
> > several vNUMA nodes and also wants to set distance among those nodes,
> > the QEMU command would like:
> > 
> > ```
> > -numa node,nodeid=0,cpus=0 \
> > -numa node,nodeid=1,cpus=1 \
> > -numa node,nodeid=2,cpus=2 \
> > -numa node,nodeid=3,cpus=3 \
> > -numa dist,src=0,dst=1,val=21 \
> > -numa dist,src=0,dst=2,val=31 \
> > -numa dist,src=0,dst=3,val=41 \
> > -numa dist,src=1,dst=2,val=21 \
> > -numa dist,src=1,dst=3,val=31 \
> > -numa dist,src=2,dst=3,val=21 \
> > ```
> > 
> > Signed-off-by: He Chen <address@hidden>
> > ---
> 
> Here is where you should mention what changed since v5, to help focus
> the attention of reviewers that have read earlier versions.
> 

Oh, sorry.
Changes since v5:
* Made the generation of the SLIT dependent on `have_numa_distance`.
* Doc refinement.
> > +++ b/qapi-schema.json
> 
> >  ##
> > +# @NumaDistOptions:
> > +#
> > +# Set the distance between 2 NUMA nodes.
> > +#
> > +# @src: source NUMA node.
> > +#
> > +# @dst: destination NUMA node.
> > +#
> > +# @val: NUMA distance from source node to destination node.
> > +#       When a node is unreachable from another node, set the distance
> > +#       between them to 255.
> 
> Still no mention that distances less than 10 are invalid, or that a node
> to itself defaults to 10 and can't be changed, or that other distances
> default to 20.  But that starts to get complex enough, and you cover it
> elsewhere, so I'm okay with what you have here.
> 
> Interface looks sane, but I'll leave others to do the code review.
> 
Is there anything I need to do to improve this patch? Still need another
version patch or just wait for the code review?

Thanks,
-He