[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util/error: Fix leak in error_vprepend()
|
From: |
Jeff Cody |
|
Subject: |
Re: [Qemu-devel] [PATCH] util/error: Fix leak in error_vprepend() |
|
Date: |
Mon, 17 Apr 2017 07:28:48 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Apr 13, 2017 at 06:09:52PM +0200, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
> util/error.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util/error.c b/util/error.c
> index 9c40b1f458..020b86b9f0 100644
> --- a/util/error.c
> +++ b/util/error.c
> @@ -134,6 +134,7 @@ void error_vprepend(Error **errp, const char *fmt,
> va_list ap)
> newmsg = g_string_new(NULL);
> g_string_vprintf(newmsg, fmt, ap);
> g_string_append(newmsg, (*errp)->msg);
> + g_free((*errp)->msg);
> (*errp)->msg = g_string_free(newmsg, 0);
> }
>
> --
> 2.12.2
>
>
Reviewed-by: Jeff Cody <address@hidden>