Re: [Qemu-devel] [PATCH 03/10] vga: add vga_scanline_invalidated helper

[Gerd Hoffmann]

> > +static bool vga_scanline_invalidated(VGACommonState *s, int y)
> > +{
> > +    if (y >= VGA_MAX_HEIGHT) {
> > +        return false;
> > +    }
> > +    return s->invalidated_y_table[y >> 5] |= 1 << (y & 0x1f);
> > +}

> The return stmt doesn't match what you're replacing.  Are you really 
> intending 
> to modify invalidated_y_table here?

No.  Really stupid cut&paste bug.  Fixed.

thanks,
  Gerd