Re: [Qemu-devel] [PATCH v3 00/21] chardev clean-ups & tests (after 2.9)

[Marc-André Lureau]

Hi

On Mon, Apr 10, 2017 at 5:58 PM Marc-André Lureau <
address@hidden> wrote:

> On Thu, Mar 16, 2017 at 10:23 AM Marc-André Lureau <
> address@hidden> wrote:
>
>> Hi,
>>
>> The following series contains various patches:
>> - replace "chardevs" list for a /chardevs container object
>> - add a few read-only socket properties mainly useful for testing
>> - some chardev related clean-ups
>> - add various chardev tests
>>
>> This series is part of a larger refactoring series that I try to keep
>> up to date here: https://github.com/elmarco/qemu/commits/chrfe
>>
>>
> ping (most of the patches are still unreviewed)
>

Patches missing reviews: 5-9, 12, 16-21

thanks

v3:
>> - open code object_new_with_props() as suggest by Paolo
>> - added some r-b tags
>> - rebased
>>
>> v2:
>> - replaced root container unref with a TODO
>> - call object_unparent() directly instead of qemu_chr_delete()
>> - remove bad qcow2 NULL check removal
>> - rebased
>>
>> Marc-André Lureau (21):
>>   char: remove qemu_chr_be_generic_open
>>   mux: simplfy muxes_realize_done
>>   xen: use a better chardev type check
>>   container: don't leak container reference
>>   char: add a /chardevs container
>>   vl: add todo note about root container cleanup
>>   char: use /chardevs container instead of chardevs list
>>   char: remove qemu_chardev_add
>>   char: remove chardevs list
>>   char: useless NULL check
>>   char-socket: introduce update_disconnected_filename()
>>   char-socket: update local address after listen
>>   char-socket: add 'addr' property
>>   char-socket: add 'connected' property
>>   char-udp: flush as much buffer as possible
>>   tests: add alias check in /char/ringbuf
>>   tests: add /char/pipe test
>>   tests: add /char/file test
>>   tests: add /char/socket test
>>   tests: add /char/udp test
>>   tests: add /char/console test
>>
>>  chardev/char-mux.h          |   2 +-
>>  include/sysemu/char.h       |  10 --
>>  chardev/char-mux.c          |  11 +-
>>  chardev/char-pty.c          |   2 +-
>>  chardev/char-socket.c       |  46 +++++-
>>  chardev/char-udp.c          |  26 ++--
>>  chardev/char.c              | 148 ++++++++----------
>>  gdbstub.c                   |   4 +-
>>  hw/usb/ccid-card-passthru.c |   2 +-
>>  hw/usb/redirect.c           |   2 +-
>>  net/vhost-user.c            |   2 +-
>>  qom/container.c             |   1 +
>>  tests/test-char.c           | 366
>> +++++++++++++++++++++++++++++++++++++++++++-
>>  tests/vhost-user-test.c     |   2 +-
>>  ui/console.c                |   2 +-
>>  ui/gtk.c                    |   2 +-
>>  vl.c                        |   1 +
>>  xen-common.c                |   2 +-
>>  18 files changed, 504 insertions(+), 127 deletions(-)
>>
>> --
>> 2.12.0.191.gc5d8de91d
>>
>>
>> --
> Marc-André Lureau
>
-- 
Marc-André Lureau