[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 19/19] monitor: remove monitor parameter from sa
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH 19/19] monitor: remove monitor parameter from save_vmstate |
|
Date: |
Tue, 18 Apr 2017 12:12:16 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> On 18/04/2017 11:44, Paolo Bonzini wrote:
>>
>>
>> On 17/04/2017 22:00, Juan Quintela wrote:
>>> load_vmstate() already use error_report, so be consistent.
>>
>> Better: make both return Error* via an Error** parameter, and add
>>
>> hmp_handle_error(mon, &err);
>>
>> to hmp_savevm and error_report_err(err) on the loading side.
>
> Not really, loadvm is also a monitor command (I was confusing it with
> -incoming). So it can use hmp_handle_error too.
ok. I did't kenw about that one.
Thanks.
- [Qemu-devel] [PATCH 16/19] migration: Export ram.c functions in its own file, (continued)
- [Qemu-devel] [PATCH 16/19] migration: Export ram.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 17/19] migration: Export rdma.c functions in its own file, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 18/19] monitor: move hmp_savevm() to monitor.c, Juan Quintela, 2017/04/17
- [Qemu-devel] [PATCH 19/19] monitor: remove monitor parameter from save_vmstate, Juan Quintela, 2017/04/17
- Re: [Qemu-devel] [PATCH 19/19] monitor: remove monitor parameter from save_vmstate, Dr. David Alan Gilbert, 2017/04/18