Re: [Qemu-devel] [PATCH 48/54] ram: Use page number instead of an address for the bitmap operations

[Juan Quintela]

"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> We use an unsigned long for the page number.  Notice that our bitmaps
>> already got that for the index, so we have that limit.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>
> see below....
>> index 7372ce2..9514044 100644
>> --- a/migration/trace-events
>> +++ b/migration/trace-events
>> @@ -63,8 +63,8 @@ put_qtailq_end(const char *name, const char *reason) "%s 
>> %s"
>>  qemu_file_fclose(void) ""
>>  
>>  # migration/ram.c
>> -get_queued_page(const char *block_name, uint64_t tmp_offset, uint64_t 
>> ram_addr) "%s/%" PRIx64 " ram_addr=%" PRIx64
>> -get_queued_page_not_dirty(const char *block_name, uint64_t tmp_offset, 
>> uint64_t ram_addr, int sent) "%s/%" PRIx64 " ram_addr=%" PRIx64 " (sent=%d)"
>> +get_queued_page(const char *block_name, uint64_t tmp_offset, unsigned long 
>> page_abs) "%s/%" PRIx64 " page_abs=%lu"
>> +get_queued_page_not_dirty(const char *block_name, uint64_t tmp_offset, 
>> unsigned long page_abs, int sent) "%s/%" PRIx64 " page_abs=%lu (sent=%d)"
>
> Yes, but if you respin, please make those %lx rather than %lu.

Done.

> Reviewed-by: Dr. David Alan Gilbert <address@hidden>