qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v13 00/20] block: Image locking series


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v13 00/20] block: Image locking series
Date: Thu, 20 Apr 2017 16:32:02 +0800
User-agent: Mutt/1.8.0 (2017-02-23)

> /var/tmp/patchew-tester-tmp-7vbaovju/src/block/file-posix.c: In function 
> ‘raw_handle_lock_update’:
> /var/tmp/patchew-tester-tmp-7vbaovju/src/block/file-posix.c:1117:17: error: 
> ‘lock_fd’ may be used uninitialized in this function 
> [-Werror=maybe-uninitialized]
>                  qemu_close(lock_fd);
>                  ^~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> /var/tmp/patchew-tester-tmp-7vbaovju/src/rules.mak:69: recipe for target 
> 'block/file-posix.o' failed

False positive. lock_fd is initialized in a "if (op == RAW_LT_PREPARE)" branch
above, and we are in a "case RAW_LT_PREPARE" switch branch too.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]