[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/15] hostmem: introduce host_memory_backend_mr_init
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 12/15] hostmem: introduce host_memory_backend_mr_inited() |
Date: |
Thu, 20 Apr 2017 15:47:02 -0300 |
From: Peter Xu <address@hidden>
We were checking this against memory region size of host memory
backend's mr field to see whether the mr has been inited. This is
efficient but less elegant. Let's make a helper for it to avoid
confusions, along with some notes.
Suggested-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
include/sysemu/hostmem.h | 1 +
backends/hostmem.c | 9 +++++++++
2 files changed, 10 insertions(+)
diff --git a/include/sysemu/hostmem.h b/include/sysemu/hostmem.h
index ecae0cff19..ed6a437f4d 100644
--- a/include/sysemu/hostmem.h
+++ b/include/sysemu/hostmem.h
@@ -62,6 +62,7 @@ struct HostMemoryBackend {
MemoryRegion mr;
};
+bool host_memory_backend_mr_inited(HostMemoryBackend *backend);
MemoryRegion *host_memory_backend_get_memory(HostMemoryBackend *backend,
Error **errp);
diff --git a/backends/hostmem.c b/backends/hostmem.c
index 89feb9ed75..d8faab4bed 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -237,6 +237,15 @@ static void host_memory_backend_init(Object *obj)
backend->prealloc = mem_prealloc;
}
+bool host_memory_backend_mr_inited(HostMemoryBackend *backend)
+{
+ /*
+ * NOTE: We forbid zero-length memory backend, so here zero means
+ * "we haven't inited the backend memory region yet".
+ */
+ return memory_region_size(&backend->mr) != 0;
+}
+
MemoryRegion *
host_memory_backend_get_memory(HostMemoryBackend *backend, Error **errp)
{
--
2.11.0.259.g40922b1
- [Qemu-devel] [PULL 01/15] memory: add section range info for IOMMU notifier, (continued)
- [Qemu-devel] [PULL 01/15] memory: add section range info for IOMMU notifier, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 03/15] memory: provide iommu_replay_all(), Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 04/15] memory: introduce memory_region_notify_one(), Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 05/15] memory: add MemoryRegionIOMMUOps.replay() callback, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 06/15] intel_iommu: use the correct memory region for device IOTLB notification, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 07/15] intel_iommu: provide its own replay() callback, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 08/15] intel_iommu: allow dynamic switch of IOMMU region, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 10/15] qdev: Make "hotplugged" property read-only, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 09/15] intel_iommu: enable remote IOTLB, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 11/15] hw/core/null-machine: Print error message when using the -kernel parameter, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 12/15] hostmem: introduce host_memory_backend_mr_inited(),
Eduardo Habkost <=
- [Qemu-devel] [PULL 13/15] hostmem: use host_memory_backend_mr_inited() where proper, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 14/15] qdev: Constify value passed to qdev_prop_set_macaddr, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 15/15] qdev: Constify local variable returned by blk_bs, Eduardo Habkost, 2017/04/20
- Re: [Qemu-devel] [PULL 00/15] Machine queue for 2.10, Peter Maydell, 2017/04/21