[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Require for English style review (was RE: [PATCH v17 0/2] v
From: |
Gonglei (Arei) |
Subject: |
[Qemu-devel] Require for English style review (was RE: [PATCH v17 0/2] virtio-crypto: virtio crypto device specification) |
Date: |
Fri, 21 Apr 2017 06:09:33 +0000 |
Hi all,
As a non-native English speaker,
I sincerely hope you give me more suggestions about English
style and/or grammar for the spec.
Thanks in advance!
-Gonglei
> -----Original Message-----
> From: Gonglei (Arei)
> Sent: Thursday, April 13, 2017 5:11 PM
> To: address@hidden; address@hidden
> Cc: Luonengjun; address@hidden; address@hidden;
> address@hidden; address@hidden; Jani Kokkonen;
> address@hidden; address@hidden; address@hidden;
> address@hidden; address@hidden; address@hidden;
> Huangweidong (C); address@hidden; address@hidden;
> address@hidden; address@hidden; address@hidden; Wubin
> (H); address@hidden; address@hidden; Zhbzg; Chenshanxi
> (Eety Chen, Euler); Zhanghuimin (Amy); Maoningning; Gonglei (Arei)
> Subject: [PATCH v17 0/2] virtio-crypto: virtio crypto device specification
>
> Thanks to Stefan, Michael, Halil, Cornelia for reviewing. The v17 has some
> big changes, so I don't add Stefan's R-by until I get a response for the
> new version :)
>
> v17 -> v16:
> - Some grammar fixes [Stefan, Halil, Michael]
> - add a section named "Supported crypto services" in order to explain bit
> numbers and valuse clearly. [Halil, Cornelia]
> - avoid word reptition [Halil]
> - rename non-session mode to stateless mode [Halil]
> - change descriptions for all elements in struct virtio_crypto_config [Halil]
> - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
> - other fixes here and there.
>
> Changes since v15:
> - use feature bits for non-session mode in order to keep compatibility with
> pre-existing code. [Halil & Michael]
> - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all
> other
> non-session mode feature bits.
> - fix some typos. [Stefan]
> - introduce struct virtio_crypto_op_data_req_mux to support both session
> and non-session based crypto operations and keep compatibility with
> pre-existing code.
>
> Changes since v14:
> - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
> - correct a sentence about dataqueue and controlq in the first paragraph.
> [Halil]
> - change a MAY to MUST about max_dataqueues. [Halil]
> - add non-session mode support
> a) add four features for different crypto services to identify wheather
> support session mode.
> b) rewrite some
>
> For pervious versions of virtio crypto spec, Pls see:
>
> [v14]:
> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html
>
> [v13]:
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html
>
> For more information, please see:
> http://qemu-project.org/Features/VirtioCrypto
>
> Please help to review, thanks.
>
> Gonglei (2):
> virtio-crypto: Add virtio crypto device specification
> virtio-crypto: Add conformance clauses
>
> acknowledgements.tex | 1 +
> conformance.tex | 29 ++
> content.tex | 2 +
> virtio-crypto.tex | 1305
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 1337 insertions(+)
> create mode 100644 virtio-crypto.tex
>
> --
> 1.7.12.4
>