qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to co


From: Anton Nefedov
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to complete
Date: Fri, 21 Apr 2017 12:43:35 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 04/21/2017 12:18 PM, Peter Lieven wrote:
Am 18.04.2017 um 12:27 schrieb Denis V. Lunev:
From: Anton Nefedov <address@hidden>

We should wait for other coroutines on error path, i.e. one of coroutines
terminates with i/o error, before cleaning the common structures. In the
other case we would crash in a lot of different places. This behaviour
was introduced by commit 2d9187bc65.

Signed-off-by: Anton Nefedov <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Peter Lieven <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Max Reitz <address@hidden>

Cc: address@hidden

This should go into 2.9.1

Peter


Actually I'm afraid the patch is incorrect.. The erroneous coroutine bails out without reentering its possible dependent coroutine so it (and the following dependents) will never finish.

I'll send out the 2nd version soon

/Anton



reply via email to

[Prev in Thread] Current Thread [Next in Thread]